Set rpath with cmake for CUDA build#2932
Merged
Merged
Conversation
awni
reviewed
Dec 19, 2025
Comment on lines
+159
to
+169
| if(MLX_BUILD_PYTHON_BINDINGS) | ||
| set_property( | ||
| TARGET mlx | ||
| APPEND | ||
| PROPERTY INSTALL_RPATH | ||
| # The paths here should match the install_requires in setup.py. | ||
| "$ORIGIN/../../nvidia/cublas/lib" | ||
| "$ORIGIN/../../nvidia/cuda_nvrtc/lib" | ||
| "$ORIGIN/../../nvidia/cudnn/lib" | ||
| "$ORIGIN/../../nvidia/nccl/lib") | ||
| endif() |
Member
There was a problem hiding this comment.
If I'm building python locally and using the system installed libraries that will still work right?
Collaborator
Author
There was a problem hiding this comment.
Yeah it still works, setting RPATH does not remove other lib search paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set RPATH with cmake directly when building python bindings instead of editing the wheel file with a script.
The RPATH is slightly changed though, before:
$ORIGIN/../../mlx_cuda_13.libs:$ORIGIN/../../nvidia/cublas/lib:$ORIGIN/../../nvidia/cuda_nvrtc/lib:$ORIGIN/../../nvidia/cudnn/lib:$ORIGIN/../../nvidia/nccl/lib
after:
$ORIGIN/../../nvidia/cublas/lib:$ORIGIN/../../nvidia/cuda_nvrtc/lib:$ORIGIN/../../nvidia/cudnn/lib:$ORIGIN/../../nvidia/nccl/lib:$ORIGIN/../../mlx_cuda_13.libs
which I think should be fine.
The
repair_linux.shcan also be removed similarly, which I will start another PR.